Unverified Commit dd0bf993 authored by Adam Paquette's avatar Adam Paquette Committed by GitHub
Browse files

Testing Valueless PVL Keyword Issues (#5573) 



* update Auto in .trn files

* update Optional in .trn files

* updated mission specific .trn files with Auto

* updated Debug in .trn files

* Account for valueless PVL keywords that are not reserved keywords

* Added dummy values for MappingGroupKeywords.pft

* Update all files that are weren't PVL compliant

* Fixed missing 'Debug' flag

* Missed a couple of test updates

* Addressed PR feeback

* Reverted if logic since keywordNameUpper is also const

* Added break when searching for reserved keyword

* reverted gtest

* Added changelog entries for PVL updates

---------

Co-authored-by: default avatarAmy Stamile <astamile@usgs.gov>
parent 14c8162d

CHANGELOG.md

+2 −0
Original line number Diff line number Diff line
@@ -44,6 +44,8 @@ release. 
### Changed

- Refactored the pixel2map app

- Updated pixel2map documentation

- Changed PVL parsing to no longer allow valueless keywords [#5573](https://github.com/DOI-USGS/ISIS3/pull/5573)

- Changed all `.trn` files with an `Auto`, `Debug` or `Optional` keyword with no value to have a value of `1` [#5573](https://github.com/DOI-USGS/ISIS3/pull/5573)



### Fixed

- Fixed noseam bug where a debugging output statement was inadvertently left in noseam.cpp.

isis/appdata/serialnumbers/Apollo15MetricSerialNumber.trn

+3 −3
Original line number Diff line number Diff line 
Group = Keyword1

  Auto

  Auto           = 1

  InputKey       = SpacecraftName

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)
@@ -9,7 +9,7 @@ Group = Keyword1 
End_Group



Group = Keyword2

  Auto

  Auto           = 1

  InputKey       = InstrumentId

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)
@@ -19,7 +19,7 @@ Group = Keyword2 
End_Group



Group = Keyword3

  Auto

  Auto           = 1

  InputKey       = StartTime

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)

isis/appdata/serialnumbers/Apollo15PanoramicSerialNumber.trn

+3 −3
Original line number Diff line number Diff line 
ObservationKeys = 3



Group = Keyword1

  Auto

  Auto           = 1

  InputKey       = SpacecraftName

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)
@@ -11,7 +11,7 @@ Group = Keyword1 
End_Group



Group = Keyword2

  Auto

  Auto           = 1

  InputKey       = InstrumentId

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)
@@ -21,7 +21,7 @@ Group = Keyword2 
End_Group



Group = Keyword3

  Auto

  Auto           = 1

  InputKey       = StartTime

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)

isis/appdata/serialnumbers/Apollo15SerialNumber.trn

+3 −3
Original line number Diff line number Diff line 
Group = Keyword1

  Auto

  Auto           = 1

  InputKey       = SpacecraftName

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)
@@ -9,7 +9,7 @@ Group = Keyword1 
End_Group



Group = Keyword2

  Auto

  Auto           = 1

  InputKey       = InstrumentId

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)
@@ -19,7 +19,7 @@ Group = Keyword2 
End_Group



Group = Keyword3

  Auto

  Auto           = 1

  InputKey       = SpacecraftClockCount

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)

isis/appdata/serialnumbers/Apollo16MetricSerialNumber.trn

+3 −3
Original line number Diff line number Diff line 
Group = Keyword1

  Auto

  Auto           = 1

  InputKey       = SpacecraftName

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)
@@ -9,7 +9,7 @@ Group = Keyword1 
End_Group



Group = Keyword2

  Auto

  Auto           = 1

  InputKey       = InstrumentId

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)
@@ -19,7 +19,7 @@ Group = Keyword2 
End_Group



Group = Keyword3

  Auto

  Auto           = 1

  InputKey       = StartTime

  InputGroup     = "IsisCube,Instrument"

  InputPosition  = (IsisCube, Instrument)