Skip to content
Unverified Commit d7f2a991 authored by Kris J. Becker's avatar Kris J. Becker Committed by GitHub
Browse files

NEAR/MSI msi2isis and MsiCamera model improvements (#4887)



* Rename NEAR/MSI main.cpp to msi2isis.cpp

Rename the NEAR/MSI ingestion app main.cpp to msi2isis.cpp to covert to callable function

* Remove old msi2isis tests in tsts directory

The old tests have been replaced by new FunctionalTests

* Update msi2isis to support new datasets

msi2isis has been modified to accept expanded datasets

* Accept images that have already been expanded to correct aspect (square pixels)
* New TRIM option added to optional turn off trimming of borders
* Modify SCLK start and stop times to be compatible with NAIF SCLK kernel format. This provides compatiblity for the sumspice application
* Save original start/stop SCLK values to new keywords OriginalSpacecraftClockStartCount/
OriginalSpacecraftClockStopCount
* Convert the app to a callable function

* Add msi2isis functional tests and data

msi2isis funtional test and data

* Converted all old app tests to new functional tests
* Added label and data files
* msi2isis has accompanying .lbl files as input but .gitignore excludes these files. Add explicit ignores for these *.lbl files

* Update MsiCamera model to support sumspice

MsiCamera model modified so that sumspice works correcty

* Use SpacecraftClockStartCount rather than StartTime to determine observation times for sumspice compatibility
* Add IAKs to track in repository
* Add light time and observer parameters to IAK version 2
* Bump camera version in plugin file due to new keywords loaded at spiceinit time

* Add MsiCamera gtest to replace old test

MsiCamera Gtest written to replace old version

* Add new MsiCamera tests and Fixtures

* Add optional keyword in serial number generation

NearMsiSerialNumber.trn update to add option keyword ControlSN to support use of simulated image in control processes

* Removed MsiCamera unit test

msiCamera unitTest.cpp in favor of NearMsiCameraCube.NearMsiCameraTest

* Add updates to CHANGELOG.md

* Add NEAR/MSI spiced cube for MsiCamera unit test

The MsiCamera requires a spiceinit cube, but .gitignore excludes .cub files. This commit addresses this issue by explicitly unignoring the Eros cube used for the test.

* Fix issues from review comments

* Removed space between issue number and url in CHANGELOG.md

msi2isis
* Remove commented code
* Simplify trimming. Let user decide uses for this option rather than assume it should not be used under certain conditions

* Cleaned up NearMsiCameraCube Fixture

* Moved NEAR MSI test to use label and ISD

* Address suggested improvements to msi2isis tests

* Updated tests after feedback from PR review

Co-authored-by: default avatarJesse Mapel <jmapel@usgs.gov>
parent 3a6ba5fa
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment