Skip to content
Unverified Commit 9a4e0dc7 authored by Jesse Mapel's avatar Jesse Mapel Committed by GitHub
Browse files

[DO NOT MERGE] OREX socetframsettings changes Fixes #5235 (#476)

* Update socetframesettings:  fix OSIRIS-REx; rename variables; cleanup.

N.B. This work was originally done in a custome socetframesettings-only
     Github repo branch here:

     https://github.com/drbitboy/isis_socetframesettings/tree/20171116/cleanup

Corrected ORX MapCam and ORX PolyCam isiscamToSocetcam matrix; other cleanup

- Add exception for non-MapCam, non-PolyCam ORX inputs; added many comments

Change variable names so the each name accurately describes the variable

Other cleanup:

- Use consistent naming for concepts
  - Ocentric; not Ocentric or BodyFixed
- Use SpiceDouble instead of double
- Use macros to initialize vectors and matrices
- Use twovec_c to calculate matrix instead of combinations of sin/cos-Lat/Lon
- Remove whitespace from blank lines
- Improve comments
- Remove else-if from assignments to isisFocalPlane2SocetPlate matrix; check
  that result is a rotation matrix
- Use vscl_c instead of loop to convert km to meters
- Eliminate radii variable
- Fix typo:  call to focalMap->DetectorLineOrigin() should be
  a call to focalMap->DetectorSampleOrigin()
- Add dummy function to to eliminate warning

* Modified socetframesettings for formatting

* Added socetframesettings mapcam test

* Added socetframesetting OREX PolyCam test
parent 8ca463ce
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment