Unverified Commit c9a429c1 authored by Amy Stamile's avatar Amy Stamile Committed by GitHub
Browse files

Build Warnings Cleanup (#5671) 

* remove unused variable warnings

* fix linux warnings

* addressed PR feedback

* fixes hinoise tests

* Fix tests
parent 3ea091fe

isis/src/base/apps/cubediff/WriteTabular.cpp

+0 −2
Original line number Diff line number Diff line
@@ -74,7 +74,6 @@ namespace Isis { 
        throw IException(IException::User, message, _FILEINFO_);

      }



      int iteration = 0;

      while((int)thisTitle.length() < (int)thisCol.Width()) {

        if(thisCol.Alignment() == Column::Left) {

          thisTitle += " ";
@@ -87,7 +86,6 @@ namespace Isis { 
          QString message = "Alignment is improperly set";

          throw IException(IException::User, message, _FILEINFO_);

        }

        iteration++;

      }//end while



      p_cols.push_back(thisCol);

isis/src/base/apps/isisminer/AssetSidebarStrategy.cpp

+0 −2
Original line number Diff line number Diff line
@@ -195,7 +195,6 @@ namespace Isis { 
                                          const ResourceList &globals) {



    // Set up incoming asset handling conditions

    int nremoved = 0;

    if ( m_removeEmpties ) {

      BOOST_FOREACH ( SharedResource resource, resources ) {

        if ( resource->isActive() ) {
@@ -208,7 +207,6 @@ namespace Isis { 
              ResourceList assetList = asset.value<ResourceList>();

              if ( assetList.size() == 0) {

                resource->removeAsset(m_asset);

                nremoved++;

              }

            }

          }

isis/src/base/apps/isisminer/RunCommandStrategy.cpp

+0 −2
Original line number Diff line number Diff line
@@ -223,7 +223,6 @@ namespace Isis { 
  int RunCommandStrategy::apply(SharedResource &resource, 

                                const ResourceList &globals) { 



    int n_good(0);

    BOOST_FOREACH ( Command command, m_commands ) {

      QString cmd = processArgs(command.m_command, m_argKeys, 

                                getGlobals(resource, globals));
@@ -248,7 +247,6 @@ namespace Isis { 
      if ( isDebug() ) { 

        cout << "Command " << command.m_name << " succeeded\n"; 

      }

        n_good++;

      }

    }

    return (1);

isis/src/base/apps/makeflat/main.cpp

+0 −2
Original line number Diff line number Diff line
@@ -381,7 +381,6 @@ void IsisMain() { 
  oLineMgr->SetLine(1);



  ProcessByBrick p;

  int excludedCnt = 0;



  if(cameraType == LineScan) {

    outputTmpAverages.resize(numOutputSamples);
@@ -392,7 +391,6 @@ void IsisMain() { 
  cubeInitialized = false;

  for(currImage = 0; currImage < inList.size(); currImage++) {

    if(Excluded(currImage)) {

      excludedCnt ++;

      continue;

    }

isis/src/base/objs/EmbreeTargetShape/EmbreeTargetShape.cpp

+1 −1
Original line number Diff line number Diff line
@@ -486,7 +486,7 @@ namespace Isis { 
    rtcSetGeometryOccludedFilterFunction(rtcMesh, EmbreeTargetShape::occlusionFilter);



    rtcCommitGeometry(rtcMesh);

    unsigned int geomID = rtcAttachGeometry(m_scene, rtcMesh);

    rtcAttachGeometry(m_scene, rtcMesh);

    rtcReleaseGeometry(rtcMesh);



    // Done, now we can perform some ray tracing