Unverified Commit 87b77046 authored by kledmundson's avatar kledmundson Committed by GitHub
Browse files

New backplane options for SunIllumination and SurfaceObliqueDetectorResolution... 


New backplane options for SunIllumination and SurfaceObliqueDetectorResolution have been added to phocube (#5488)

* Added sun illumination mask backplane.

phocube
 * Added robust implementation to determine solar illumination on body considering terrain occlusion
* Added app test for this option
* Updated documentation describing this new feature

* Add SurfaceObliqueDetectorResoluton plane

* phocube - This new plane is in addition to the existing ObliqueDetectorResolution. The difference is ObliqueDetectorResolution uses the local (shape model) emission angle and SurfaceObliqueDetectorResolution uses the emission angle calculated from the ellipsoid.

Signed-off-by: default avatarKris J. Becker <kbecker@orex.lpl.arizona.edu>

* Added phocube options to create SUNILLUMINATIONMASK and SURFACEOBLIQUEDETECTORRESOLUTION backplanes. Added gtests for these options. Updated documentation and added an example. Addresses #5467.

* Removed unwanted phocube test Makefile, input, and truth data obtained via cherry-pick from U. of Arizona codebase. Addresses #5467.

* Minor updates to phocube app, documentation, and gtests. Addresses #5467.

* Modified .gitignore to enable upload of phocube test cube; updated CHANGELOG.md for phocube backplane additions. Addresses #5467.

* Minor documentation update and removal of unneeded include file. Addresses #5467.

* Per reviewer comments: 1) replaced cam->DetectorResolution() with cam->ObliqueDetectorResolution(false), where "false" refers to the useLocal parameter; and 2) fixed typo in phocube.xml. Addresses #5467.

* Second try on addressing reviewer comment on "cam->ObliqueDetectorResolution(false)" in phocube.cpp. Addresses

* Updated gtest FunctionalTestPhocubeSurfaceObliqueDetectorResolution. Addresses #5467.

---------

Signed-off-by: default avatarKris J. Becker <kbecker@orex.lpl.arizona.edu>
Co-authored-by: default avatarKris J. Becker <kbecker@orex.lpl.arizona.edu>
parent 589b4434

.gitignore

+3 −0
Original line number Diff line number Diff line
@@ -63,6 +63,9 @@ install/ 
# Unignore mosrange cube files in data area as input files require these

!isis/tests/data/mosrange/*.cub



# Unignore phocube cube files in data area as input files require these

!isis/tests/data/phocube/*.cub



# Ensure the contents of ISISDATA mockup tests are preserved

!isis/tests/data/isisdata/mockup/**/*

CHANGELOG.md

+3 −1
Original line number Diff line number Diff line
@@ -35,12 +35,14 @@ release. 


## [Unreleased]



### Added

- Added backplane options for SunIllumination and SurfaceObliqueDetectorResolution to phocube [#5467](https://github.com/DOI-USGS/ISIS3/issues/5467)



### Changed

- Added jigsaw error message for csminit'd images without csm parameters[#5486](https://github.com/DOI-USGS/ISIS3/issues/5486)

- Changed `qwt` dependency version to 6.2.0 or below [#5498](https://github.com/DOI-USGS/ISIS3/issues/5498)

- Pinned `suitesparse` dependency version to maximum not including 7.7.0 [#5496](https://github.com/DOI-USGS/ISIS3/issues/5496)





### Fixed

- Fixed a bug in QVIEW's FindTool in which camera was prioritized over projction [#5508](https://github.com/DOI-USGS/ISIS3/issues/5508)

- Fixed a bug in PolygonTools in which the program exited before attempting to fix an invalid Polygon [#5520](https://github.com/DOI-USGS/ISIS3/issues/5520)

isis/src/base/apps/phocube/assets/images/20190425T211232S312_map_iofL2pan.png

0 → 100644
+341 KiB
Loading image diff...

isis/src/base/apps/phocube/assets/images/phocube_gui_example2.jpg

0 → 100644
+69.5 KiB
Loading image diff...

isis/src/base/apps/phocube/assets/images/phocube_sun_illumination_band.png

0 → 100644
+151 KiB
Loading image diff...